globalDefinitions.hpp includes "classfile_constants.h", with a comment that it is needed before including <jvm.h>. But jvm.h includes jvm_constants.h, which includes classfile_constants.h, as it should because using stuff from there. Presumably it didn't used to and there was an include order problem as a result, which got fixed (IMO) poorly.
So the include in globalDefintions.hpp is no longer needed for that purpose. Of course, there might be some other reason for needing that include. Investigate and clean up.
(This was noticed during the review ofJDK-8363584.)
So the include in globalDefintions.hpp is no longer needed for that purpose. Of course, there might be some other reason for needing that include. Investigate and clean up.
(This was noticed during the review of
- relates to
-
JDK-8231844 Enhance type signature characters in classfile_constants.h and improve the JVM to use type signature characters more consistently
-
- Resolved
-
- links to
-
Review(master)
openjdk/jdk/26573