Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8364488

Missing @Override in JSLC

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P4 P4
    • tbd
    • jfx24
    • javafx
    • None

      Came out of this review: https://github.com/openjdk/jfx/pull/1824

      A number of classes have missing @Override annotations:

      ```
      Description Resource Type Path Location
      The method accept(TreeVisitor) of type ArrayAccessExpr should be tagged with @Override since it actually overrides a superinterface method ArrayAccessExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 49
      The method accept(TreeVisitor) of type BinaryExpr should be tagged with @Override since it actually overrides a superinterface method BinaryExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 97
      The method accept(TreeVisitor) of type BreakStmt should be tagged with @Override since it actually overrides a superinterface method BreakStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 34
      The method accept(TreeVisitor) of type CallExpr should be tagged with @Override since it actually overrides a superinterface method CallExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 52
      The method accept(TreeVisitor) of type CompoundStmt should be tagged with @Override since it actually overrides a superinterface method CompoundStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 44
      The method accept(TreeVisitor) of type ContinueStmt should be tagged with @Override since it actually overrides a superinterface method ContinueStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 34
      The method accept(TreeVisitor) of type DeclStmt should be tagged with @Override since it actually overrides a superinterface method DeclStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 44
      The method accept(TreeVisitor) of type DiscardStmt should be tagged with @Override since it actually overrides a superinterface method DiscardStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 34
      The method accept(TreeVisitor) of type DoWhileStmt should be tagged with @Override since it actually overrides a superinterface method DoWhileStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 48
      The method accept(TreeVisitor) of type ExprStmt should be tagged with @Override since it actually overrides a superinterface method ExprStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 42
      The method accept(TreeVisitor) of type FieldSelectExpr should be tagged with @Override since it actually overrides a superinterface method FieldSelectExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 63
      The method accept(TreeVisitor) of type ForStmt should be tagged with @Override since it actually overrides a superinterface method ForStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 74
      The method accept(TreeVisitor) of type FuncDef should be tagged with @Override since it actually overrides a superinterface method FuncDef.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 50
      The method accept(TreeVisitor) of type GlueBlock should be tagged with @Override since it actually overrides a superinterface method GlueBlock.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 42
      The method accept(TreeVisitor) of type LiteralExpr should be tagged with @Override since it actually overrides a superinterface method LiteralExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 45
      The method accept(TreeVisitor) of type ParenExpr should be tagged with @Override since it actually overrides a superinterface method ParenExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 43
      The method accept(TreeVisitor) of type ProgramUnit should be tagged with @Override since it actually overrides a superinterface method ProgramUnit.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 44
      The method accept(TreeVisitor) of type ReturnStmt should be tagged with @Override since it actually overrides a superinterface method ReturnStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 42
      The method accept(TreeVisitor) of type SelectStmt should be tagged with @Override since it actually overrides a superinterface method SelectStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 54
      The method accept(TreeVisitor) of type UnaryExpr should be tagged with @Override since it actually overrides a superinterface method UnaryExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 51
      The method accept(TreeVisitor) of type VarDecl should be tagged with @Override since it actually overrides a superinterface method VarDecl.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 50
      The method accept(TreeVisitor) of type VariableExpr should be tagged with @Override since it actually overrides a superinterface method VariableExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 45
      The method accept(TreeVisitor) of type VectorCtorExpr should be tagged with @Override since it actually overrides a superinterface method VectorCtorExpr.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 52
      The method accept(TreeVisitor) of type WhileStmt should be tagged with @Override since it actually overrides a superinterface method WhileStmt.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/tree line 49
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 182
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 219
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 234
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 254
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 292
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 322
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 349
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 370
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 386
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 413
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 429
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 458
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 474
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 500
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method JSWFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/java line 516
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 193
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 244
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 259
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 279
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 317
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 347
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 374
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 395
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 411
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 438
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 454
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 483
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 499
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 525
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method MEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/me line 541
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 183
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 220
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 235
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 255
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 293
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 323
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 350
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 371
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 387
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 414
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 430
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 459
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 475
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 501
      The method toString(int, List<Expr>) of type new FuncImpl(){} should be tagged with @Override since it actually overrides a superclass method SSEFuncImpls.java Java Problem /graphics/src/jslc/java/com/sun/scenario/effect/compiler/backend/sw/sse line 517

      ```

            arapte Ambarish Rapte
            angorya Andy Goryachev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: