There are some stale comment references, searching for closeDescriptors:
src/hotspot/os/aix/os_aix.cpp: // appropriate file descriptors (e.g. as we do in closeDescriptors in
src/hotspot/os/bsd/os_bsd.cpp: // appropriate file descriptors (e.g. as we do in closeDescriptors in
src/hotspot/os/linux/os_linux.cpp: // (e.g. as we do in closeDescriptors in UNIXProcess.c), and this in
src/java.base/unix/native/libjava/childproc.c: Closing pipe fds here is redundant, since closeDescriptors()
Since:
8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()
in src/java.base/unix/native/libjava/childproc.c
closeDesciptors was renamed:
-closeDescriptors(void)
+markDescriptorsCloseOnExec(void)
(Noticed while reviewingJDK-8364312.)
UNIXProcess.c reference not related to 8210549. May relate to what was previously jdk/src/solaris/native/java/lang/UNIXProcess_md.c may mean the current ./src/java.base/unix/native/libjava/ProcessImpl_md.c
src/hotspot/os/aix/os_aix.cpp: // appropriate file descriptors (e.g. as we do in closeDescriptors in
src/hotspot/os/bsd/os_bsd.cpp: // appropriate file descriptors (e.g. as we do in closeDescriptors in
src/hotspot/os/linux/os_linux.cpp: // (e.g. as we do in closeDescriptors in UNIXProcess.c), and this in
src/java.base/unix/native/libjava/childproc.c: Closing pipe fds here is redundant, since closeDescriptors()
Since:
8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()
in src/java.base/unix/native/libjava/childproc.c
closeDesciptors was renamed:
-closeDescriptors(void)
+markDescriptorsCloseOnExec(void)
(Noticed while reviewing
UNIXProcess.c reference not related to 8210549. May relate to what was previously jdk/src/solaris/native/java/lang/UNIXProcess_md.c may mean the current ./src/java.base/unix/native/libjava/ProcessImpl_md.c
- relates to
-
JDK-8210549 Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()
-
- Resolved
-
- links to
-
Commit(master) openjdk/jdk/83953c45
-
Review(master) openjdk/jdk/26667