Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8364822

Comment cleanup, stale references to closeDescriptors and UNIXProcess.c

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 26
    • None
    • core-libs
    • None
    • master

      There are some stale comment references, searching for closeDescriptors:

      src/hotspot/os/aix/os_aix.cpp: // appropriate file descriptors (e.g. as we do in closeDescriptors in
      src/hotspot/os/bsd/os_bsd.cpp: // appropriate file descriptors (e.g. as we do in closeDescriptors in
      src/hotspot/os/linux/os_linux.cpp: // (e.g. as we do in closeDescriptors in UNIXProcess.c), and this in
      src/java.base/unix/native/libjava/childproc.c: Closing pipe fds here is redundant, since closeDescriptors()


      Since:
      8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()

      in src/java.base/unix/native/libjava/childproc.c

      closeDesciptors was renamed:

      -closeDescriptors(void)
      +markDescriptorsCloseOnExec(void)


      (Noticed while reviewing JDK-8364312.)

      UNIXProcess.c reference not related to 8210549. May relate to what was previously jdk/src/solaris/native/java/lang/UNIXProcess_md.c may mean the current ./src/java.base/unix/native/libjava/ProcessImpl_md.c

            ghan Guanqiang Han
            kevinw Kevin Walls
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: