Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8364970

Redo JDK-8327381 by updating the CmpU type instead of the Bool type

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • tbd
    • 24, 25
    • hotspot

      The refactor in JDK-8327381 moved the BoolNode::Value_cmpu_and_mask transformations from BoolNode::Ideal to BoolNode::Value. After that, we found that the transformation was leaving the CmpU and Bool types in an inconsistent state.

      If we simply adjust the CmpU type as TypeInt::CC_LE (case 1a) or TypeInt::CC_LT (case 1b) [1], the BoolNode type will automatically be adjusted by the types' propagation of BoolTest::cc2logical [2][3].

      [1] https://github.com/openjdk/jdk/blob/jdk-26+8/src/hotspot/share/opto/type.cpp#L495-L500
      [2] https://github.com/openjdk/jdk/blob/jdk-26+8/src/hotspot/share/opto/subnode.cpp#L1356-L1370
      [3] https://github.com/openjdk/jdk/blob/jdk-26+8/src/hotspot/share/opto/subnode.cpp#L1910

            fferrari Francisco Ferrari Bihurriet
            fferrari Francisco Ferrari Bihurriet
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: