objArrayKlass::allocate_instance() in Valhalla is a public method currently.
Since Valhalla complicates allocation of arrays, with different "flavors" (ArrayProperties), it would be best to mark it private, and only allow the oopFactory to use it.
Ad-hoc uses elsewhere will be hard to maintain as ArrayProperties evolve.
Note there may remain "friend" use from mainline allowing circumvention (i.e. Deoptimization).
Since Valhalla complicates allocation of arrays, with different "flavors" (ArrayProperties), it would be best to mark it private, and only allow the oopFactory to use it.
Ad-hoc uses elsewhere will be hard to maintain as ArrayProperties evolve.
Note there may remain "friend" use from mainline allowing circumvention (i.e. Deoptimization).
- relates to
-
JDK-8367989 Remove InstanceKlass::allocate_objArray and ArrayKlass::allocate_arrayArray
-
- Resolved
-
- links to
-
Commit(lworld)
openjdk/valhalla/77d067c9
-
Commit(lworld)
openjdk/valhalla/18097d41
-
Review(lworld)
openjdk/valhalla/1602
-
Review(lworld)
openjdk/valhalla/1628