Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8367546

Clarify meaning of "corresponding header" for architecture-qualified .inline.hpp files

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • docs

      During the review of JDK-8367320 we stumbled on the lack of a clear indication of what constitutes the "corresponding .hpp" file for a .inline.hpp file having an architecture qualifier.

      For example, "continuationHelper_x86.inline.hpp" includes "runtime/continuationHelper.hpp", and the include statement is on top as stated in the style guide:

      #ifndef CPU_X86_CONTINUATIONHELPER_X86_INLINE_HPP
      #define CPU_X86_CONTINUATIONHELPER_X86_INLINE_HPP

      #include "runtime/continuationHelper.hpp"

      #include "runtime/continuationEntry.inline.hpp"
      #include "runtime/frame.inline.hpp"
      #include "runtime/registerMap.hpp"
      [...]

      However, this order is not respected by SortIncludes.java, which does not designate "runtime/continuationHelper.hpp" as the "corresponding .hpp file". If this concept was clarified in the style guide, we could improve SortIncludes accordingly.

      I attached the output of "find src/hotspot -type f -regex '.*_.*.inline.hpp'".

            fandreuzzi Francesco Andreuzzi
            fandreuzzi Francesco Andreuzzi
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: