Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8368072

Remove redundant arguments of MarkingNMethodClosure

XMLWordPrintable

    • gc

      All users of this class use the same value for the latter 2 arguments.
      MarkingNMethodClosure(OopClosure* cl, bool fix_relocations, bool keepalive_nmethods)

      fix_relocations = false
      keepalive_nmethods = true

      Users:

      G1FullGCMarkTask::work
      PCAddThreadRootsMarkingTaskClosure
      SerialFullGC::phase1_mark
      ShenandoahSTWRootScanner::roots_do

      Semantically, MarkingNMethodClosure can be used to identify live (on-stack) nmethods during full-gc marking, so no relocation should occur and encountered nmethods should be marked live. Therefore, these two bool args should have those values built in.

            ayang Albert Yang
            ayang Albert Yang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: