P4
1. SigningPackageTwoStepTest test has a few issues:
- It doesn't test the case of bundling an unsigned predefined app image into a signed pkg installer. Add missing test case. The test case should verify there are "warning.unsigned.app.image" [1] and "warning.per.user.app.image.signed" [2] warnings in jpackage output.
- It tests bundling of an unsigned predefined app image into an unsigned pkg installer. None of the involved parties are signed. This test case duplicates AppImagePackageTest and should be removed.
2. Verify that without "--mac-sign" option, jpackage produces app images with a valid "adhoc" signature.
[1] https://github.com/openjdk/jdk/blob/0cb8ccd89a659eaf1e245cfb7f8c32fb16bff4c7/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java#L63
[2] https://github.com/openjdk/jdk/blob/0cb8ccd89a659eaf1e245cfb7f8c32fb16bff4c7/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java#L54
- It doesn't test the case of bundling an unsigned predefined app image into a signed pkg installer. Add missing test case. The test case should verify there are "warning.unsigned.app.image" [1] and "warning.per.user.app.image.signed" [2] warnings in jpackage output.
- It tests bundling of an unsigned predefined app image into an unsigned pkg installer. None of the involved parties are signed. This test case duplicates AppImagePackageTest and should be removed.
2. Verify that without "--mac-sign" option, jpackage produces app images with a valid "adhoc" signature.
[1] https://github.com/openjdk/jdk/blob/0cb8ccd89a659eaf1e245cfb7f8c32fb16bff4c7/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java#L63
[2] https://github.com/openjdk/jdk/blob/0cb8ccd89a659eaf1e245cfb7f8c32fb16bff4c7/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java#L54
- links to
-
Commit(master)
openjdk/jdk/2aa0efd4
-
Review(master)
openjdk/jdk/27875