There are a few types of errors in jpackage jtreg test descriptions:
1. Misuse of the "jpackagePlatformPackage" jtreg key. Initially, it was meant to be used with the tests that produce installable native packages, which implied that they would have been used in SQE tests.
Later, we added tests that create installable native packages, but they are not supposed to be installed and used by SQE. For example, WinOSConditionTest [1], DmgContentTest [2]. These tests still have the "jpackagePlatformPackage" jtreg key. But they shouldn't, as they are not meant for SQE testing. They should only be executed as part of JDK test tier runs.
The "jpackagePlatformPackage" key name should be "jpackagePlatformPackageForSQE," but it is less intrusive to keep the name unchanged, merely redefine its semantics, and revisit its use in the test declarations.
2. Another misuse of the "jpackagePlatformPackage" key when it is added to the tests that don't create installable native packages. E.g.: RuntimeImageSymbolicLinksTest [3]
3. Tests with the "jpackagePlatformPackage" key, but SQE doesn't use them in their testing. There is no point in including these tests when SQE runs jpackage tests to get the packages for SQE testing. Such tests should have "@requires (jpackage.test.SQETest == null)" but they don't. E.g.: SigningPackageTwoStepTest [4].
[1] https://github.com/openjdk/jdk/blob/ed36b9bb6f3d429db6accfb3b096e50e7f2217ff/test/jdk/tools/jpackage/windows/WinOSConditionTest.java
[2] https://github.com/openjdk/jdk/blob/ed36b9bb6f3d429db6accfb3b096e50e7f2217ff/test/jdk/tools/jpackage/macosx/DmgContentTest.java
[3] https://github.com/openjdk/jdk/blob/ed36b9bb6f3d429db6accfb3b096e50e7f2217ff/test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java
[4] https://github.com/openjdk/jdk/blob/a2196e20608a1acd12c84ecfb8522bf1666545f4/test/jdk/tools/jpackage/macosx/SigningPackageTwoStepTest.java
1. Misuse of the "jpackagePlatformPackage" jtreg key. Initially, it was meant to be used with the tests that produce installable native packages, which implied that they would have been used in SQE tests.
Later, we added tests that create installable native packages, but they are not supposed to be installed and used by SQE. For example, WinOSConditionTest [1], DmgContentTest [2]. These tests still have the "jpackagePlatformPackage" jtreg key. But they shouldn't, as they are not meant for SQE testing. They should only be executed as part of JDK test tier runs.
The "jpackagePlatformPackage" key name should be "jpackagePlatformPackageForSQE," but it is less intrusive to keep the name unchanged, merely redefine its semantics, and revisit its use in the test declarations.
2. Another misuse of the "jpackagePlatformPackage" key when it is added to the tests that don't create installable native packages. E.g.: RuntimeImageSymbolicLinksTest [3]
3. Tests with the "jpackagePlatformPackage" key, but SQE doesn't use them in their testing. There is no point in including these tests when SQE runs jpackage tests to get the packages for SQE testing. Such tests should have "@requires (jpackage.test.SQETest == null)" but they don't. E.g.: SigningPackageTwoStepTest [4].
[1] https://github.com/openjdk/jdk/blob/ed36b9bb6f3d429db6accfb3b096e50e7f2217ff/test/jdk/tools/jpackage/windows/WinOSConditionTest.java
[2] https://github.com/openjdk/jdk/blob/ed36b9bb6f3d429db6accfb3b096e50e7f2217ff/test/jdk/tools/jpackage/macosx/DmgContentTest.java
[3] https://github.com/openjdk/jdk/blob/ed36b9bb6f3d429db6accfb3b096e50e7f2217ff/test/jdk/tools/jpackage/share/RuntimeImageSymbolicLinksTest.java
[4] https://github.com/openjdk/jdk/blob/a2196e20608a1acd12c84ecfb8522bf1666545f4/test/jdk/tools/jpackage/macosx/SigningPackageTwoStepTest.java
- duplicates
-
JDK-8370963 Errors in jpackage jtreg test descriptions
-
- Resolved
-