A DESCRIPTION OF THE PROBLEM :
From HashtableBase definition:
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/utilities/hashTable.hpp#L252-L254
In AdapterHandlerLibrary:
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/runtime/sharedRuntime.cpp#L3403
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/runtime/sharedRuntime.cpp#L3430
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/runtime/sharedRuntime.cpp#L3444
Shouldn't the logic be inverted?
Inline assignments also don't work with the current logic.
If that's a bug, there may be other places with incorrect logic. I have not looked further.
From HashtableBase definition:
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/utilities/hashTable.hpp#L252-L254
In AdapterHandlerLibrary:
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/runtime/sharedRuntime.cpp#L3403
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/runtime/sharedRuntime.cpp#L3430
https://github.com/openjdk/jdk/blob/9f972008ff2beb4b69855f4c42b8a664a6b8bc95/src/hotspot/share/runtime/sharedRuntime.cpp#L3444
Shouldn't the logic be inverted?
Inline assignments also don't work with the current logic.
If that's a bug, there may be other places with incorrect logic. I have not looked further.
- links to
-
Review(master)
openjdk/jdk/28197