Clean up unused `CheckSanity` method from java_md_common.c file

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: P4
    • 27
    • Affects Version/s: 8, 11, 17, 21, 25, 27
    • Component/s: tools
    • None
    • b02
    • generic
    • linux

      In mainline it is just cleaning up the unused `CheckSanity` method from java_md_common.c file

      The issue in JDK 8 is "GCC 14.2.0 reports warning: '%s' directive output may be truncated"
      This issue is observed in 8u, but it is applicable in mainline as well. Problematic code in `CheckSanity` function.

      https://github.com/openjdk/jdk/blob/master/src/java.base/unix/native/libjli/java_md_common.c#L274

      /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/solaris/bin/java_md_common.c: In function 'CheckSanity':
      /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/solaris/bin/java_md_common.c:192:46: warning: '%s' directive output may be truncated writing up to 4085 bytes into a region of size between 10 and 4095 [-Wformat-truncation=]
        192 | JLI_Snprintf(buffer, sizeof(buffer), "%s/%s/bin/java", path, dir);
            | ^~
      In file included from /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/solaris/bin/java_md.h:36,
                       from /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/share/bin/java.h:41,
                       from /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/solaris/bin/java_md_common.c:25:
      /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/share/bin/jli_util.h:80:41: note: 'snprintf' output between 11 and 8181 bytes into a destination of size 4096
         80 | #define JLI_Snprintf snprintf
      /tank/fmatte/repos/git/jdk8u-cpu/jdk/src/solaris/bin/java_md_common.c:192:5: note: in expansion of macro 'JLI_Snprintf'
        192 | JLI_Snprintf(buffer, sizeof(buffer), "%s/%s/bin/java", path, dir);
            | ^~~~~~~~~~~~

            Assignee:
            Fairoz Matte
            Reporter:
            Fairoz Matte
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: