This was spotted when investigating JDK-8367623. AllocateNode::Ideal_allocation was used to check if an Ideal optimization must be carried out. Since that code was also executed after macro nodes are removed, it led to unexpected results.

AllocateNode::Ideal_allocation looks for an Allocate node, and this only makes sense if such nodes are allowed. We should enforce this with an assert.