StyleAttributeMap.Builder.setParagraphDirection()

XMLWordPrintable

    • Type: CSR
    • Resolution: Approved
    • Priority: P4
    • jfx26, jfx27
    • Component/s: javafx
    • None
    • source, binary
    • low
    • This is a breaking change in a feature being incubated.
    • Java API
    • JDK

      Summary

      Rename incorrectly named setRTL(ParagraphDirection) to setParagraphDirection(ParagraphDirection) in the StyleAttributeMap.Builder class.

      Problem

      The method retained old name after refactoring.

      Solution

      Rename, to be consistent with StyleAttributeMap.PARAGRAPH_DIRECTION and StyleAttributeMap.getParagraphDirection()

      Specification

      diff --git a/modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyleAttributeMap.java b/modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyleAttributeMap.java
      index 714145f..c31b83e 100644
      --- a/modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyleAttributeMap.java
      +++ b/modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyleAttributeMap.java
      @@ -585,7 +585,7 @@
                * @param d the paragraph direction
                * @return this Builder instance
                */
      -        public Builder setRTL(ParagraphDirection d) {
      +        public Builder setParagraphDirection(ParagraphDirection d) {
                   set(PARAGRAPH_DIRECTION, d);
                   return this;
               }
      

            Assignee:
            Andy Goryachev
            Reporter:
            Andy Goryachev
            Kevin Rushforth
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: