There are a few places in jpackage impl/tests where opened I/O streams are left unclosed:
- Files.newInputStream(...) without the corresponding Closeable#close() call at [1], [2], [3], [4], [5]
- Class#getResourceAsStream(...) without the corresponding Closeable#close() call at [6]
Add missing Closeable#close() calls, use try-with-resource blocks, or use a different API.
[1] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/AppImageInfoPListFile.java#L53
[2] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java#L165
[3] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AppImageFile.java#L135
[4] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/macosx/HostArchPkgTest.java#L68
[5] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/windows/WinLongVersionTest.java#L184
[6] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LauncherVerifier.java#L460
- Files.newInputStream(...) without the corresponding Closeable#close() call at [1], [2], [3], [4], [5]
- Class#getResourceAsStream(...) without the corresponding Closeable#close() call at [6]
Add missing Closeable#close() calls, use try-with-resource blocks, or use a different API.
[1] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/AppImageInfoPListFile.java#L53
[2] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java#L165
[3] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AppImageFile.java#L135
[4] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/macosx/HostArchPkgTest.java#L68
[5] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/windows/WinLongVersionTest.java#L184
[6] https://github.com/openjdk/jdk/blob/1fb5030ab351a52b4a7455cbdd57f5b50aab9bd5/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LauncherVerifier.java#L460
- links to
-
Commit(master)
openjdk/jdk/74faf033
-
Review(master)
openjdk/jdk/29007