-
Type:
Bug
-
Resolution: Fixed
-
Priority:
P4
-
Affects Version/s: 27
-
Component/s: hotspot
-
master
vmTestbase comment typo: preallocated exceptions are unrelated to "lunch"
$ grep -r lunch test
test/hotspot/jtreg/vmTestbase/nsk/share/gc/Algorithms.java: * exception we preallocate it before the lunch starts. It means
test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java: * exception we preallocate it before the lunch starts. It means
test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java: * exception we preallocate it before the lunch starts. It means
test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java: * exception we preallocate it before the lunch starts. It means
test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java: // Useful for turning up subtle bugs: Use -infinite and run while at lunch.
(The DateFormatRoundTripTest occurrence is not a typo, it means you could eat lunch while the test runs in a certain mode.)
These might be a typo for "launch".
Or they might be intentional, could "the lunch" be a reference to what the "eatMemory" method does.
Maybe it should be "meal"? test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java has eatMemoryImpl which catches OutOfMemoryError and returns numberOfOOMEs.
But better to remove the comment. It is also not preallocated as described.
$ grep -r lunch test
test/hotspot/jtreg/vmTestbase/nsk/share/gc/Algorithms.java: * exception we preallocate it before the lunch starts. It means
test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java: * exception we preallocate it before the lunch starts. It means
test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java: * exception we preallocate it before the lunch starts. It means
test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java: * exception we preallocate it before the lunch starts. It means
test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java: // Useful for turning up subtle bugs: Use -infinite and run while at lunch.
(The DateFormatRoundTripTest occurrence is not a typo, it means you could eat lunch while the test runs in a certain mode.)
These might be a typo for "launch".
Or they might be intentional, could "the lunch" be a reference to what the "eatMemory" method does.
Maybe it should be "meal"? test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java has eatMemoryImpl which catches OutOfMemoryError and returns numberOfOOMEs.
But better to remove the comment. It is also not preallocated as described.
- links to
-
Commit(master)
openjdk/jdk/c8c6e700
-
Review(master)
openjdk/jdk/29126