idea.sh script adds source paths in a single, enormous, line to jdk.iml

XMLWordPrintable

    • Type: Bug
    • Resolution: Unresolved
    • Priority: P4
    • None
    • Affects Version/s: 27
    • Component/s: infrastructure
    • In Review

      While working on ideas to post-process the IntelliJ files created by idea.sh, I noticed that it adds the sources entries for modules as a single line (>1k chars long).
      This could be added as one-line-per-entry very easily.

      The change would be limited to just idea.sh itself:
      --------
      +# SOURCES is a single string containing embeded newlines.
       for root in $MODULE_ROOTS; do
           if [ "x$CYGPATH" != "x" ]; then
             root=`$CYGPATH -am $root`
           elif [ "x$WSL_DISTRO_NAME" != "x" ]; then
             root=`wslpath -am $root`
           fi
      -
      - SOURCES=$SOURCES" $SOURCE_PREFIX""$root""$SOURCE_POSTFIX"
      + # Add line termination/indentation for everything after the first entry.
      + if [ "x$SOURCES" != "x" ]; then
      + SOURCES="${SOURCES}\n "
      + fi
      + SOURCES="${SOURCES}${SOURCE_PREFIX}${root}${SOURCE_POSTFIX}"
      --------

            Assignee:
            David Beaumont
            Reporter:
            David Beaumont
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: