ZipFile.Source.Key should not hold on to its BasicFileAttributes instance

XMLWordPrintable

    • Type: Enhancement
    • Resolution: Fixed
    • Priority: P4
    • 27
    • Affects Version/s: None
    • Component/s: core-libs

      ZipFile.Source.Key uses BasicFileAttributes to compare file keys and last modified time in the hashCode and equals methods.

      By capturing these two fields in the Key constructor instead we make the BasicFileAttributes available for GC and the code easier to reason about.

      It should also performance positive, since we create the FileTime instance once and aviod synchronization for the file key capture.

            Assignee:
            Eirik Bjørsnøs
            Reporter:
            Eirik Bjørsnøs
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: