Parallel: Remove special treatment in JstatGcCapacityResults.java

XMLWordPrintable

    • Type: Enhancement
    • Resolution: Unresolved
    • Priority: P4
    • None
    • Affects Version/s: None
    • Component/s: hotspot
    • svc

      The following comment is incorrect after JDK-8338977 -- the EC part will occupy the rest of the young-gen (NGC), therefore, the relation is strict equality. The if-part can be removed.

      ```
      // Verify relative size of NGC and S0C + S1C + EC.
      // The rule depends on if the tenured GC is parallel or not.
      // For parallell GC: NGC >= S0C + S1C + EC
      // For non-parallell GC: NGC == S0C + S1C + EC
      boolean isTenuredParallelGC = isTenuredParallelGC();
      String errMsg = String.format(
              "NGC %s (S0C + S1C + EC) (NGC = %.1f, S0C = %.1f, S1C = %.1f, EC = %.1f, (S0C + S1C + EC) = %.1f)",
              isTenuredParallelGC ? "<" : "!=", NGC, S0C, S1C, EC, S0C + S1C + EC);
      if (isTenuredParallelGC) {
          assertThat(NGC >= S0C + S1C + EC, errMsg);
      } else {
          assertThat(checkFloatIsSum(NGC, S0C, S1C, EC), errMsg);
      }
      ```

            Assignee:
            Albert Yang
            Reporter:
            Albert Yang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: