With JDK-8373134 fixed, and JDK-8374896 shortly to be fixed, the following section in `PhaseIterGVN::verify_Identity_for` can now be removed:
```
// MaxNode::find_identity_operation
// Finds patterns like Max(A, Max(A, B)) -> Max(A, B)
// This can be a 2-hop search, so maybe notification is not
// good enough.
//
// Found with:
// compiler/codegen/TestBooleanVect.java
// -XX:VerifyIterativeGVN=1110
case Op_MaxL:
case Op_MinL:
case Op_MaxI:
case Op_MinI:
case Op_MaxF:
case Op_MinF:
case Op_MaxHF:
case Op_MinHF:
case Op_MaxD:
case Op_MinD:
return;
```
To be specific, the fix inJDK-8373134 already made compiler/codegen/TestBooleanVect.java with verify iterative gvn pass, but it was decided to leave removing this section out of the original PR due to JDK-8374896 (see https://github.com/openjdk/jdk/pull/28895#issuecomment-3737207951).
So, once JDK-8374896 is fixed, removing this section can go ahead.
```
// MaxNode::find_identity_operation
// Finds patterns like Max(A, Max(A, B)) -> Max(A, B)
// This can be a 2-hop search, so maybe notification is not
// good enough.
//
// Found with:
// compiler/codegen/TestBooleanVect.java
// -XX:VerifyIterativeGVN=1110
case Op_MaxL:
case Op_MinL:
case Op_MaxI:
case Op_MinI:
case Op_MaxF:
case Op_MinF:
case Op_MaxHF:
case Op_MinHF:
case Op_MaxD:
case Op_MinD:
return;
```
To be specific, the fix in
So, once JDK-8374896 is fixed, removing this section can go ahead.
- relates to
-
JDK-8374896 Min/Max identity optimization opportunities missing for int and long
-
- Open
-
-
JDK-8373134 C2: Min/Max users of Min/Max uses should be enqueued for GVN
-
- Resolved
-