compiler/c2/irTests/TestFloat16ScalarOperations.java is fragile in the presence of special constants

XMLWordPrintable

      I saw a failure in testRandomFP16ConstantPatternSet1, the issue is that x/c can be transformed into x*1/c for some special constants c. This leads to IR verification failure. In the failure I observed, c = 0.25.

      Error output:
      For random generator using seed: -1965009995454176622
      To re-run test with same seed value please add "-Djdk.test.lib.random.seed=-1965009995454176622" to command line.
      The following scenarios have failed: #1
      Scenario #1
      ===========
      Scenario flags: [--add-modules=jdk.incubator.vector]

      Command Line:
      linux-aarch64-debug.jdk/jdk-27/fastdebug/bin/java --enable-preview -Dir.framework.server.port=35829 --add-modules=jdk.incubator.vector -XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions -XX:+LogCompilation -XX:CompilerDirectivesFile=test-vm-compile-commands-pid-1537609.log -XX:CompilerDirectivesLimit=301 -XX:-OmitStackTraceInFastThrow -DShouldDoIRVerification=true -XX:-BackgroundCompilation -XX:CompileCommand=quiet compiler.lib.ir_framework.test.TestVM TestFloat16ScalarOperations

      One or more @IR rules failed:
      Failed IR Rules (1) of Methods (1)
      ----------------------------------
      1) Method "public short TestFloat16ScalarOperations.testRandomFP16ConstantPatternSet1()" - [Failed IR rules: 1]:
         * @IR rule 2: "@compiler.lib.ir_framework.IR(phase={DEFAULT}, applyIfPlatformAnd={}, applyIfCPUFeatureOr={}, counts={"_#ADD_HF#_", " >0 ", "_#SUB_HF#_", " >0 ", "_#MUL_HF#_", " >0 ", "_#DIV_HF#_", " >0 "}, failOn={}, applyIfPlatform={}, applyIfPlatformOr={}, applyIfOr={}, applyIfCPUFeatureAnd={"fphp", "true", "asimdhp", "true"}, applyIf={}, applyIfCPUFeature={}, applyIfAnd={}, applyIfNot={})"
           > Phase "PrintIdeal":
             - counts: Graph contains wrong number of nodes:
               * Constraint 4: "(\d+(\s){2}(DivHF.*)+(\s){2}===.*)"
                 - Failed comparison: [found] 0 > 0 [given]
                 - No nodes matched!

            Assignee:
            Unassigned
            Reporter:
            Quan Anh Mai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: