[lworld] Make decision to not flatten static fields explicit in FieldLayoutBuilder

XMLWordPrintable

      The function `field_layout_selection` which is used to decide how layout the fields of class does not handle the static fields case explicitly.

      Right now it depends on a subtle interaction with parsing and preloading classes where we have a short circuit for static field which means we do not add an InlineLayoutInfo for the static fields, which in turn makes the `field_layout_selection` think that this field is not a known value class and ends up using a reference.

      This is both hard to understand and might cause bugs in the future. I suggest we add and explicit return LayoutKind::REFERENCE; when the field is static in `field_layout_selection`.

            Assignee:
            Axel Boldt-Christmas
            Reporter:
            Axel Boldt-Christmas
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: