Uploaded image for project: 'Java Mission Control'
  1. Java Mission Control
  2. JMC-4526

The connection wizard should not recreate nested wizards

XMLWordPrintable

      In ActionWizardPage.getNextPage new wizards are instantiated for each call, which causes WizardDialog.setWizard to add and create controls for more and more wizards, which is an unnecessary resource leak. The problem can be observed by tracking the number of created controls for each Next-Back iteration.

      It also causes the WizardDialog.updateSizeForWizard to increase the shell size for each call if the help tray is open and the dialog content area is not wide enough for the page. In the UI it can be seen by doing the following:
      1) Choose File -> Connect...
      2) Press the question mark to open the help tray
      3) Choose a discovered jvm and press Next
      4) Make the dialog content area very narrow
      5) Choose either 'Start Flight Recording...' or 'Control the Remote JMX Agent' and press Next
      6) Press Back
      7) Repeat 5 and 6 a couple of times
      Result) The help tray gets wider and wider
      The fact that the help tray gets wider is probably another bug in jface, but it shouldn’t be such a big problem if we do not recreate the wizard for each iteration.

            Unassigned Unassigned
            jringdah Johan Ringdahl (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: