Uploaded image for project: 'Java Mission Control'
  1. Java Mission Control
  2. JMC-6523

Investigate why Compare CPU rule uses warning limit to compute the score instead of info limit

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3 P3
    • 8.3.1
    • None
    • Mission Control Core
    • None

      From Florian:

      To compute the score, the longest span is searched with SpanToolkit.getMaxSpanLimit() which uses warning limit to combine or not spans together. However the rule is triggered when the score is above the info limit.

      This could be a bug or an expected behaviour depending on how getMaxSpanLimit() computes the longest span. We should either fix the bug or make it clearer why the warning limit is used here.

      Original comment from Jie:
      It’s curious that the SpanToolkit is given the warning limit whereas
      the long message is generated if the score is above the info limit. As
      well, the warning limit is used to determine if spans get combined
      while the end result used for the score process is the longest span,
      regardless of its value’s relation to the warning limit. Should it be
      the longest span that’s above the warning limit, if possible,
      otherwise the longest span? I guess it depends on if the initial spans
      vary in length or not. I’m not sure how to describe it but something
      feels strange here.

            Unassigned Unassigned
            hirt Marcus Hirt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: