Uploaded image for project: 'Java Mission Control'
  1. Java Mission Control
  2. JMC-6654

Fix Formatting Scripts for Windows

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • Infrastructure
    • None

      The GH Action Scripts for Windows do not run correctly. For example, the formatting script does not make it past the call to run the p2 site
      "mvn p2:site"

       

      I'm guessing there are some syntax issues in the script.

       

      Script:
      https://github.com/openjdk/jmc/blob/master/scripts/checkformatting.bat

       

      Example run:

      https://github.com/jiekang/jmc/commit/ca9102e217958b8e5f3064ef6511ded27b015e8f/checks?check_suite_id=351610527

       

      Note the formatting fails on linux/mac but passes on windows. It passes because spotless was never executed.

       

            Unassigned Unassigned
            jkang Jie Kang
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: