Uploaded image for project: 'Java Mission Control'
  1. Java Mission Control
  2. JMC-8114

Verify fixed uitests in ControlRecordingsTest on jdk 17

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9.1.0
    • None
    • Mission Control Client
    • None

      As noted by @grandmasterpixel in the pull-request for JMC-8112 [0], there were a few uitest failures impacting the upstream master branch. One of those was in JfrWizardTest, and was addressed by JMC-8113.

      The remaining three are in ControlRecordingsTest, and are modifyRecordingEvents(), modifyEventThreshold(), and modifyEventPeriod()

      I don't often see modifyEventPeriod fail, but have encountered the other two regularly, they fail with:

      ControlRecordingsTest.modifyEventThreshold:324 Event "Compilation" threshold
      value should be 5 ms but was: 1 s
      ControlRecordingsTest.modifyRecordingEvents:277 Event "Allocation Requiring GC" should be turned on
       

      JMC-8112 looks to have been caused by the availability of the new security jfr events and a layout change to the event template in the jfr wizard. I'm curious if these are also a result of the jdk 17 bump that we encountered with the latest eclipse platform update.

      [0] https://github.com/openjdk/jmc/pull/502#issuecomment-1653863203

      Edit (Feb 20, 2024):

      There was another Jira ticket (https://bugs.openjdk.org/browse/JMC-8175) opened to address these same failing uitests, and it has been resolved by temporarily commenting out those problematic tests. I've re-worded this Jira ticket to handle the verification of a fix if/when it happens. It turns out there is currently an issue with jdk.ActiveSetting in jdk17, but a fix has been added to 19+. In the event the patch gets backported to jdk17, these tests should be re-enabled and checked to make sure they're running as expected.

            aptmac Alex Macdonald
            aptmac Alex Macdonald
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: