Uploaded image for project: 'Java Mission Control'
  1. Java Mission Control
  2. JMC-8174

Check license year script may check files not changed by a PR

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9.0.0
    • None
    • Infrastructure
    • None

      Over the last couple of weeks, there have been some PR checks that have had the check license script fail due to checking files that were not directly included in the PR commits. For the most part, I've noticed the script was checking and failing when looking at the files that moved from rjmx -> rjmx.common, regardless of if those files were touched in the commit.

      I think I've figured it out, at the moment the script works by comparing the diff between the PR and origin/master [0]. This only works if origin/master is up-to-date, which isn't always the case. This should be fixed to create a diff against the master branch of the actual JMC repo and the PR commits instead.

       [0] https://github.com/openjdk/jmc/blob/master/scripts/checkcopyrightyear.sh#L4

            aptmac Alex Macdonald
            aptmac Alex Macdonald
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: