Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1201

Multiple command reply messages include 'HostUserDetails'

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • bots

      A DESCRIPTION OF THE PROBLEM :
      The command reply of multiple commands erroneously (?) contains `@HostUserDetails{...}`, for example https://github.com/openjdk/jdk/pull/4382#issuecomment-901430117

      The issue appears to be that some commands print '@' followed by the `HostUser`. At least for pull request commands this seems to be redundant because PullRequestCommandWorkItem.processCommand already includes that.

      For commit commands the situation is slightly different because CommitCommandWorkItem.processCommand is apparently not adding the prefix `@username`.

      It might therefore be good to:
      (- Adjust CommitCommandWorkItem.processCommand to always print `@username ` as prefix similar to PullRequestCommandWorkItem)
      - Remove all `@username` printing in pull request (and commit) command implementations



            ihse Magnus Ihse Bursie
            webbuggrp Webbug Group
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: