Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1318

PR comments can be out-of-order in the email and run into each other

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • bots
    • None

      I'm now noticing some emails from PR's are collating comments in a way that makes the email very awkward to read/understand.

      For example in:

      https://github.com/openjdk/jdk/pull/7079

      I made two comments (one stand-alone and one as part of approving the change):

      ------------
      dholmes-ora commented 11 minutes ago

      Thanks Thomas! I was too focused on the original string and didn't check that the exception code was going to make a copy anyway. There's likely multiple copies made on the way to the final String object.

      dholmes-ora approved these changes 10 minutes ago

      dholmes-ora left a comment

      Seems fine.

      Thanks,
      David
      ------------

      but the email that was sent flipped the order and just ran them together, so the email has:

      ------------
      Seems fine.

      Thanks,
      David

      Thanks Thomas! I was too focused on the original string and didn't check that the exception code was going to make a copy anyway. There's likely multiple copies made on the way to the final String object.

      -------------


      I would have expected the comments to be presented in the order in which they were written, and that there would be some kind of delimiter between them so you could tell they were distinct comments.

            Unassigned Unassigned
            dholmes David Holmes
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: