Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1437

Fix the OpenJDK official role name and pluralization

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • bots
    • None

      Reported by Magnus at https://github.com/openjdk/skara/pull/1305#discussion_r870240534

      However, I think this was incorrect. The code here makes the text appears as:

      Change must be properly reviewed (1 review required, with at least 1 reviewer)

      when it should have been:

      Change must be properly reviewed (1 review required, with at least 1 Reviewer)

      (Note the capitalization of Reviewer).

      Traditionally, the (not very clear, I admit) distinction has been made in OpenJDK between "reviewer" (anyone who offers a review) and a "Reviewer" (a member with the official status as Reviewer for a project). This text is about the latter, so changing the "r" to a "R" in the message made a significant difference.

            gli Guoxiong Li
            gli Guoxiong Li
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: