Reported by Magnus at https://github.com/openjdk/skara/pull/1305#discussion_r870240534
However, I think this was incorrect. The code here makes the text appears as:
Change must be properly reviewed (1 review required, with at least 1 reviewer)
when it should have been:
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
(Note the capitalization of Reviewer).
Traditionally, the (not very clear, I admit) distinction has been made in OpenJDK between "reviewer" (anyone who offers a review) and a "Reviewer" (a member with the official status as Reviewer for a project). This text is about the latter, so changing the "r" to a "R" in the message made a significant difference.
However, I think this was incorrect. The code here makes the text appears as:
Change must be properly reviewed (1 review required, with at least 1 reviewer)
when it should have been:
Change must be properly reviewed (1 review required, with at least 1 Reviewer)
(Note the capitalization of Reviewer).
Traditionally, the (not very clear, I admit) distinction has been made in OpenJDK between "reviewer" (anyone who offers a review) and a "Reviewer" (a member with the official status as Reviewer for a project). This text is about the latter, so changing the "r" to a "R" in the message made a significant difference.
- relates to
-
SKARA-1428 New reviews message always adds plural 's'
-
- Resolved
-
-
SKARA-282 Make the review requirements more explicit in the progress list
-
- Resolved
-