Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1568

Dependency PR Resolution Detection Does Not Check Means of Resolution

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • bots
    • None

      When a PR that dependency on another PR is closed, the dependent PR is updated to apply against the master branch:

      https://github.com/openjdk/jdk8u-dev/pull/71#event-7078228994

      However, SKARA does not seem to take into account that the PR may have been closed for other reasons than integration. In this case, the dependency, https://github.com/openjdk/jdk8u-dev/pull/66, timed out, but SKARA still tried to update the dependent as if it had been integrated.

      I only spotted this when trying to work out what the AArch64 changes were in the changes on GitHub. These changes were not in the generated webrev https://openjdk.github.io/cr/?repo=jdk8u-dev&pr=71&range=01

            gli Guoxiong Li
            andrew Andrew Hughes
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: