The target branch (destination) of a pull request is a fundamental aspect of that pull request. If the target of a PR changes after a PR is approved, the prior approvals should be invalidated. An approval to integrate into one branch should not imply approval to integrate into any branch.
This should be done regardless of whether or not the repo is configured to require re-reviews when a new commit is pushed.
Careful review is required when the target of a PR is changed from one branch to another, both to ensure that commits unrelated to the existing PR are not inadvertently brought into the new branch, and to check whether a PR is suitable for the new branch.
This RFE is a prerequisite to using stabilization branches for the jdk, presuming that we want to make such a change for stabilization.
This should be done regardless of whether or not the repo is configured to require re-reviews when a new commit is pushed.
Careful review is required when the target of a PR is changed from one branch to another, both to ensure that commits unrelated to the existing PR are not inadvertently brought into the new branch, and to check whether a PR is suitable for the new branch.
This RFE is a prerequisite to using stabilization branches for the jdk, presuming that we want to make such a change for stabilization.
- relates to
-
SKARA-1628 Restore 'createdAt' in GraphQL queries
-
- Resolved
-
-
SKARA-1809 Skara dismissing reviews on dependent PRs
-
- Closed
-