Adding review comments should not mean approval status change

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: P4
    • 1.0
    • Affects Version/s: None
    • Component/s: bots
    • None

      In Github, if a user leaves additional comments using the "Review changes" dialog, and selects the "Comments", then their approval is considered revoked. This is surprising. Selecting "Changes requested" should be considered a revoke of the approval, but just adding comments should not change the state of approval.

            Assignee:
            Zhao Song
            Reporter:
            Magnus Ihse Bursie
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: