Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1603

Make labels handling consistent in all Issue implementations

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 1.0
    • None
    • libraries
    • None

      When investigating SKARA-1602, I realized that the way labels are handled in the new TestIssue/TestPullRequest is consistent with JiraIssue, but not with GitHubPullRequest and GitLabMergeRequest. This discrepancy may be hiding buggy behavior, or will at least risk introducing bugs in the future.

      In JiraIssue, the add/remove/set label methods only updates the server through a REST call, but the locally cached value does not change. This is also how TestIssue was implemented. But in the PullRequest implementations, add/remove/set label also updates the local cache, so that future labels/labelNames calls will reflect those updates.

      I think the most consistent behavior would be to make all implementations update the cache so that added or removed labels are properly reflected. This should cause the least confusion.

            zsong Zhao Song
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: