Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1611

Improve adding and removing of labels in GitLab

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • libraries
    • None

      The current implementation for adding and removing labels in GitLab gets all current labels from the MR, modifies the returned set and then sets all labels. That was likely the only way of doing it when the code was written. Looking at the Gitlab API today, there is "add_labels" and "remove_labels" on a merge_request, and I have manually verified that they work. We should change our implementation to use these instead to avoid potential races between bots.

            zsong Zhao Song
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: