Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1673

CSR bot should be able to handle a withdrawn CSR properly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 1.0
    • None
    • bots
    • None

    Description

      A user reported that skara bot keeps changing the description in his MR.

      After investigation, we found a bug related with CSR bot.

      The user linked a CSR issue with the main issue(JDK-8231610), and after that, he found CSR unneeded and withdrawn the CSR issue.

      However, our logic about handling withdrawn CSR issue has some problem.

      In PullRequestWorkItem#run, the bot would add updateMarker(<!-- csr: ‘update’ -->) to the PR body regardless of the state of CSR issue. And if a PR body contains the updateMarker, it will be updated periodically until the body contains a CSR progress. However, since our CSR issue is withdrawn, the CSR label would not be added to the pr and CSR progress would not be added to the PR body. So it will be an endless loop.

      In summary, the bug would happen in such a case, the user withdraw the csr issue before the csr issue bot first time run.

      Attachments

        Issue Links

          Activity

            People

              zsong Zhao Song
              zsong Zhao Song
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: