Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1682

PullRequestBot::getPeriodicItems takes too long

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 1.0
    • None
    • bots
    • None

    Description

      Similar to the NotifyBot in SKARA-1680, the PullRequestBot is also suffering from spending a very long time in the very first round of getPeriodicItems after a bot restart. The last time we redeployed this bot, it took ~40 minutes. This was long enough to trigger several users to ask if Skara was having issues.

      The cause is similar. There is an "isReady" call for each PR, which checks for comments. The comment checking here is even worse than for the NotifyBot because every PR is checked for comments, not just those that match the "rfr" or "integrated" labels.

      My proposed solution is similar. We need to move this expensive evaluation to the relevant WorkItems where they can run concurrently instead of serially in getPeriodicItems.

      Attachments

        Issue Links

          Activity

            People

              erikj Erik Joelsson
              erikj Erik Joelsson
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: