P2
When CSRBot looks for a suitable issue in a set of Backports and main bug, it gets the fixVersion from the target branch of the PR. This is conceptually wrong, as the PR may be including a change to the fixVersion, and if that is the case, any associated bug should be resolved with fixVersion set to the value the PR changed it to.
We currently have this PR where exactly that is happening:
https://github.com/openjdk/jdk/pull/10924
The associated bugs have fixVersion correctly set to 21, as this is the initial change for bumping the JDK version from 20 to 21. This is causing CSRBot to not be able to find the linked CSR issues.
The same kind of logic is also present in PullRequestBot, and unfortunately the methods are copied. The reason for this is the lack of a common place to put application level shared logic for multiple bots. I'm going to introduce a new module with this change where such common logic can be housed, and put the updated version extraction logic there.
We currently have this PR where exactly that is happening:
https://github.com/openjdk/jdk/pull/10924
The associated bugs have fixVersion correctly set to 21, as this is the initial change for bumping the JDK version from 20 to 21. This is causing CSRBot to not be able to find the linked CSR issues.
The same kind of logic is also present in PullRequestBot, and unfortunately the methods are copied. The reason for this is the lack of a common place to put application level shared logic for multiple bots. I'm going to introduce a new module with this change where such common logic can be housed, and put the updated version extraction logic there.
- relates to
-
SKARA-1547 Collect PR specific constants in single shared class
-
- Resolved
-
