Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1722

Add duration logging for RestRequestCache lock

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P3 P3
    • 1.0
    • None
    • libraries
    • None

      In the RestRequestCache, we are using locking to help us adhere to GitHub best practices for rate limits. More details can be found here:

      https://docs.github.com/en/rest/guides/best-practices-for-integrators?apiVersion=2022-11-28#dealing-with-abuse-rate-limits

      I've come to realize that this is most likely the biggest limiter for bot performance during startup. The duration logging I added for rest requests (and several other places) isn't currently taking the locking into account, so the time it takes to make remote calls during bot startup/warmup is severely under reported.

      I would like to change this by adding some more logging in this class.

            erikj Erik Joelsson
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: