Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2003

Timing out lock in RestRequestCache stops the bot

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • admin
    • None

      In RestRequestCache, there is a lock to prevent concurrent calls to services like github. This lock has a hard coded timeout of 10 minutes and if that ever hits, it calls System.exit(1). I think this is a bit drastic, especially since the intention of this action isn't logged, just printed to stderr.

      I think a more appropriate action would be to throw an exception. The exception would then be logged SEVERE automatically by the BotRunner.

      Last night the mlbridge bot exited because of this.

            zsong Zhao Song
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: