Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2016

CSRIssueBot shouldn't force CheckWorkItem to run

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 1.0
    • None
    • bots
    • None

      While investigating SKARA-2015, I noted that CSRIssueBot is handling CheckWorkItem in a different, and even worse way. It forces a bypass of the checksum check. I don't think this is needed. When a CSR issue is associated with a PR, it's already included in the checksum check, so a change to the CSR would trigger re-evaluation. The only problem is triggering association of new CSR issues correctly. I think we can handle this by detecting that a CSR association may be new in CSRIssueWorkItem. This should be doable by looking in the prIssueMap. This map isn't currently holding CSR issues, but that should be easily fixable. If the CSR issue isn't present in the prIssueMap, we supply it as an extra input to CheckWorkItem. The CheckWorkItem can then check if it's present in the prBody. If it isn't, this should bypass the checksum check and force re-evaluation.

      This idea may still need some more deliberation.

            zsong Zhao Song
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: