Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2091

CheckRun fails with NPE if github fullName is null

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2 P2
    • 1.0
    • None
    • bots
    • None

      This PR is currently failing to be evaluated because the author's github user has the field fullName set to null. https://github.com/openjdk/jdk/pull/16468

      java.lang.RuntimeException: Exception during jcheck
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.checkStatus(CheckRun.java:1418)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.execute(CheckRun.java:117)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckWorkItem.prRun(CheckWorkItem.java:630)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.PullRequestWorkItem.run(PullRequestWorkItem.java:126)
      at org.openjdk.skara.bot/org.openjdk.skara.bot.BotRunner$RunnableWorkItem.runMeasured(BotRunner.java:217)
      at org.openjdk.skara.bot/org.openjdk.skara.bot.BotRunner$RunnableWorkItem.run(BotRunner.java:172)
      at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
      at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
      at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
      at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
      at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
      at java.base/java.lang.Thread.run(Thread.java:833)
      Caused by: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.openjdk.skara.host.HostUser.fullName()" is null
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.addFullNameWarningComment(CheckRun.java:1067)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.updateMergeReadyComment(CheckRun.java:1089)
      at org.openjdk.skara.bots.pr/org.openjdk.skara.bots.pr.CheckRun.checkStatus(CheckRun.java:1350)

            zsong Zhao Song
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: