It's time to update the JDK used to run Skara. I would like to use JDK 21 and since Gradle 8.5 now supports it, we can finally go ahead.
While running tests with JDK 21, I discovered two issues:
1. There is a JSON parser test that assumes element order in a HashMap.
2.JDK-8289689 is tripping up a RepositoryTest about unicode.
1 is easy to fix. 2 is trickier but I think have figured out what's happening. At least on macos, java.nio used to always normalize unicode to NFD. This hid the fact that Git automatically normalizes to NFC. I'm rewriting the test to explicitly deal with both composed and decomposed encodings of filenames.
While running tests with JDK 21, I discovered two issues:
1. There is a JSON parser test that assumes element order in a HashMap.
2.
1 is easy to fix. 2 is trickier but I think have figured out what's happening. At least on macos, java.nio used to always normalize unicode to NFD. This hid the fact that Git automatically normalizes to NFC. I'm rewriting the test to explicitly deal with both composed and decomposed encodings of filenames.