Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2131

Make second jcheck run work on merge-style PR

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • bots
    • None

      When testing SKARA-2115, I find that if we change the jcheck conf in the source branch. the pr will NOT run jcheck against the localJCheckConf(merged conf of source and target JCheckConf).
      After investigation, I realized that this bug exists since the first time we introduced the second jcheck run feature. This bug was partly fixed by introducing IsJCheckConfUpdatedInMergePR.
      However, IsJCheckConfUpdatedInMergePR will only be set correctly when workItem.bot.jcheckMerge() is true.
      To fix it, we should set isJCheckConfUpdatedInMergePR correctly when the PR is a merge-style PR.

            zsong Zhao Song
            zsong Zhao Song
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: