When testing SKARA-2115, I find that if we change the jcheck conf in the source branch. the pr will NOT run jcheck against the localJCheckConf(merged conf of source and target JCheckConf).
After investigation, I realized that this bug exists since the first time we introduced the second jcheck run feature. This bug was partly fixed by introducing IsJCheckConfUpdatedInMergePR.
However, IsJCheckConfUpdatedInMergePR will only be set correctly when workItem.bot.jcheckMerge() is true.
To fix it, we should set isJCheckConfUpdatedInMergePR correctly when the PR is a merge-style PR.
After investigation, I realized that this bug exists since the first time we introduced the second jcheck run feature. This bug was partly fixed by introducing IsJCheckConfUpdatedInMergePR.
However, IsJCheckConfUpdatedInMergePR will only be set correctly when workItem.bot.jcheckMerge() is true.
To fix it, we should set isJCheckConfUpdatedInMergePR correctly when the PR is a merge-style PR.