Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2213

Record reviewers with stale reviews in the commit message

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • bots
    • None

      Some projects like jfx are configured to not count stale reviews, requiring a re-review whenever the PR changes due to a change in the source branch. In such cases, Skara correctly does not "count" stale reviews for the purpose of satisfying the requirements for minimum number of reviewers.

      Once that minimum is satisfied by up-to-date reviews, I think it should record all reviewers in the "Reviewed-by" line of the commit, even those with stale reviews. This would be similar to the way Skara records, but does not count, reviewers who are manually added with the `/reviewer credit` command.

            zsong Zhao Song
            kcr Kevin Rushforth
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: