Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2300

Do not list non-OpenJDK reviewers in Reviewers list

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 1.0
    • None
    • bots
    • None

      Any arbitrary GitHub user can go to an OpenJDK PR and add a review. We can't really stop that, but when it happens Skara will add a line:

      @random-dude (no known openjdk.org user name / role)

      to the Reviewers list in the summary.

      We should not do that. Such a review carry no meaning, and the commit message will not include them anyway. The GitHub UI will show that the user left a GitHub review, but the Skara tooling should reflect only the reviews that we care about.

            zsong Zhao Song
            ihse Magnus Ihse Bursie
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: