Any arbitrary GitHub user can go to an OpenJDK PR and add a review. We can't really stop that, but when it happens Skara will add a line:
@random-dude (no known openjdk.org user name / role)
to the Reviewers list in the summary.
We should not do that. Such a review carry no meaning, and the commit message will not include them anyway. The GitHub UI will show that the user left a GitHub review, but the Skara tooling should reflect only the reviews that we care about.
@random-dude (no known openjdk.org user name / role)
to the Reviewers list in the summary.
We should not do that. Such a review carry no meaning, and the commit message will not include them anyway. The GitHub UI will show that the user left a GitHub review, but the Skara tooling should reflect only the reviews that we care about.
- links to
-
Commit(master) openjdk/skara/6e4b2b81
-
Review(master) openjdk/skara/1693