-
Bug
-
Resolution: Unresolved
-
P3
-
None
-
None
-
None
On GitHub PRs, the jcheck "binary" check doesn't detect a binary file that has been replaced.
For GitLab PRs, it also doesn't detect a new binary file (the check appears to do nothing on GitLab).
JDK-8334166 (jdk) and JDK-8334657 (jfx) enable Skara's binary check, which will show a warning when a PR has a binary file. This works for a newly added binary file, but does not work when an existing file is replaced with a different binary file.
Here are 3 Draft PRs that show the problem:
https://github.com/openjdk/jfx/pull/1478 : add binary file (OK)
https://github.com/openjdk/jfx/pull/1480 : replace existing binary file (FAIL)
https://github.com/openjdk/jfx/pull/1481 : both adds binary file (OK) and replaces existing binary file (FAIL)
For GitLab PRs, it also doesn't detect a new binary file (the check appears to do nothing on GitLab).
Here are 3 Draft PRs that show the problem:
https://github.com/openjdk/jfx/pull/1478 : add binary file (OK)
https://github.com/openjdk/jfx/pull/1480 : replace existing binary file (FAIL)
https://github.com/openjdk/jfx/pull/1481 : both adds binary file (OK) and replaces existing binary file (FAIL)
- relates to
-
JDK-8334657 Enable binary check
- Resolved
-
JDK-8334166 Enable binary check
- Resolved
-
SKARA-2289 Flag binary files in a PR
- Open