-
Bug
-
Resolution: Unresolved
-
P4
-
None
-
None
-
None
There is a /clean command in Skara to force a PR to be declared clean, but there is no corresponding command to allow that decision to be revoked, whether it was made by /clean or automatically by the bot.
This PR I just opened would be a good example:
https://github.com/openjdk/jdk21u-dev/pull/826
The backport was not clean. Indeed, the /backport command could not do it automatically; https://github.com/openjdk/jdk/commit/ff49f677ee5017019c90823bc412ceb90068ffbd#commitcomment-143887746
I was thus surprised when the Skara bot decided it was clean; https://github.com/openjdk/jdk21u-dev/pull/826#event-13409335374
There appears to be no way to reserve this decision so the backport is actually flagged for review. It also makes me wonder what fuzziness Skara applies to declaring something clean.
I also wonder if the author of the PR should be prevented from using /clean but, now that we have the approval commands, it is not the big loophole it once was, where a author could have committed a backport patch with just submit, /clean and /integrate.
This PR I just opened would be a good example:
https://github.com/openjdk/jdk21u-dev/pull/826
The backport was not clean. Indeed, the /backport command could not do it automatically; https://github.com/openjdk/jdk/commit/ff49f677ee5017019c90823bc412ceb90068ffbd#commitcomment-143887746
I was thus surprised when the Skara bot decided it was clean; https://github.com/openjdk/jdk21u-dev/pull/826#event-13409335374
There appears to be no way to reserve this decision so the backport is actually flagged for review. It also makes me wonder what fuzziness Skara applies to declaring something clean.
I also wonder if the author of the PR should be prevented from using /clean but, now that we have the approval commands, it is not the big loophole it once was, where a author could have committed a backport patch with just submit, /clean and /integrate.
- relates to
-
SKARA-1335 Improve handling clean backports and the /clean command.
- Open