Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2390

jcheck whitespace or executable failures should not prevent a PR from being rfr

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • bots
    • None

      A PR in a repository that is configured with jcheck whitespace or executable files checks cannot be integrated until those checks pass.

      The current behavior for those checks is that they will also prevent that PR from becoming rfr until they pass. This seems overly restrictive, since there is value in reviewing functional aspects of a PR even if there are whitespace errors.

      Compounding the problem, there is no clear indication that there is a problem making it easy to miss the fact that no email has been sent for the PR.

      The Enhancement proposes to treat whitespace errors as an integration blocker rather than a review blocker, making it more like the problem of a mismatched PR title and JBS title. As part of this, it should show up in the list of integration blockers.

            zsong Zhao Song
            kcr Kevin Rushforth
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: