P4
As Pavel pointed out in the pull request of SKARA-2410(https://github.com/openjdk/skara/pull/1697), with current implementation , GitCommits::close may have created multiple processes and only destroy one of them.
As Erik and Pavel suggested, we should make sure close() is called on each process.
As Erik and Pavel suggested, we should make sure close() is called on each process.
- relates to
-
SKARA-2410 Introduce process killing finally block in GitCommits
-
- Resolved
-
- links to
-
Commit(master)
openjdk/skara/a42517c6
-
Review(master)
openjdk/skara/1699