Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2420

Remove closed pr from all entries in targetRefPRMap

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 1.0
    • None
    • bots
    • None

      In SKARA-1937, we introduced a feature that pull request bot can re-evaluate all PRs when jcheck configuration changes. When implementing it, I let pull request bot maintains a hash map called targetRefPRMap. The key is the name of targetRef and the value is the list of pr which targets to the targetRef. Currently, when a pr is closed, the bot will unlink it with its current targetRef. There was an issue happened recently, there was an entry {pr/96=[pr/97]} in the hash map, and before pr/97 was integrated, the user retargeted the pr from pr/96 to master, so the bot fails to remove the association between pr/96 and pr/97.

      I think the right behavior here is that when pull request bot finds an updated pr, it should unlink this pr with all targetRefs and if this pr is still open, the bot should link the pr with current targetRef.

            zsong Zhao Song
            zsong Zhao Song
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: